Removed all the debug comments added to the database by the sitelink script. Noted another defect in the todo list.

git-svn-id: file:///svn-source/pmgr/branches/yafr_20090716@415 97e9348a-65ac-dc4b-aefc-98561f571b83

scripts/sitelink2pmgr.pl

@@ -963,7 +963,7 @@ foreach $row (@{query($sdbh, $query)}) {
       'moveout_date' => datefmt($row->{'DateOut'}),
       'close_date' => datefmt($row->{'DateClosed'}),
       'rent' => $row->{'Rent'},
-      'comment' => "LedgerID: $row->{'LedgerID'}",
+      #'comment' => "LedgerID: $row->{'LedgerID'}",
 	  });
 
    $newdb{'lookup'}{'ledger'}{$row->{'LedgerID'}}{'lease_id'} =
@@ -1065,7 +1065,7 @@ foreach $row (@{query($sdbh, $query)}) {
          'ledger_id' => $newdb{'lookup'}{'charge'}{$row->{'ChargeID'}}{$_.'_ledger_id'},
          'crdr' => $CRDR,
          'amount' => $newdb{'lookup'}{'charge'}{$row->{'ChargeID'}}{'amount'},
-         'comment' => "$_ Ledger Entry: $row->{'ChargeID'}; Ledger: $row->{'LedgerID'}",
+         #'comment' => "$_ Ledger Entry: $row->{'ChargeID'}; Ledger: $row->{'LedgerID'}",
              });
 
       $newdb{'lookup'}{'charge'}{$row->{'ChargeID'}}{$_.'_entry_id'}
@@ -1076,7 +1076,7 @@ foreach $row (@{query($sdbh, $query)}) {
       #'transaction_id' => $newdb{'lookup'}{'charge'}{$row->{'ChargeID'}}{'invoice'}{'id'},
       'debit_entry_id' => $newdb{'lookup'}{'charge'}{$row->{'ChargeID'}}{'debit_entry_id'},
       'credit_entry_id' => $newdb{'lookup'}{'charge'}{$row->{'ChargeID'}}{'credit_entry_id'},
-      'comment' => "Double Entry: $row->{'ChargeID'}; Ledger: $row->{'LedgerID'}",
+      #'comment' => "Double Entry: $row->{'ChargeID'}; Ledger: $row->{'LedgerID'}",
           });
 
    $newdb{'lookup'}{'charge'}{$row->{'ChargeID'}}{'double_entry_id'}
@@ -1092,7 +1092,7 @@ foreach $row (@{query($sdbh, $query)}) {
       'lease_id' => $newdb{'lookup'}{'charge'}{$row->{'ChargeID'}}{'lease_id'},
       'account_id' => $newdb{'lookup'}{'charge'}{$row->{'ChargeID'}}{'credit_account_id'},
       'amount' => $newdb{'lookup'}{'charge'}{$row->{'ChargeID'}}{'amount'},
-      'comment' => "Charge: $row->{'ChargeID'}; Ledger: $row->{'LedgerID'}",
+      #'comment' => "Charge: $row->{'ChargeID'}; Ledger: $row->{'LedgerID'}",
           });
 
    $newdb{'lookup'}{'charge'}{$row->{'ChargeID'}}{'statement_entry_id'}
@@ -1219,7 +1219,7 @@ foreach $row (@{query($sdbh, $query)}) {
       'account_id' => $newdb{'lookup'}{'receipt'}{$row->{'ReceiptNum'}}{$row->{'PaymentType'}}{'credit_account_id'},
       'ledger_id' => $newdb{'lookup'}{'receipt'}{$row->{'ReceiptNum'}}{$row->{'PaymentType'}}{'credit_ledger_id'},
       'crdr' => 'CREDIT',
-      'comment' => "Receipt: $row->{'ReceiptNum'}; Type: $row->{'PaymentType'}",
+      #'comment' => "Receipt: $row->{'ReceiptNum'}; Type: $row->{'PaymentType'}",
 	  });
 
    $newdb{'lookup'}{'receipt'}{$row->{'ReceiptNum'}}{$row->{'PaymentType'}}{'receipt_id'}
@@ -1238,7 +1238,7 @@ foreach $row (@{query($sdbh, $query)}) {
          'ledger_id'  => $newdb{'lookup'}{'receipt'}{$row->{'ReceiptNum'}}{$row->{'PaymentType'}}{$_.'_ledger_id'},
          'crdr' => $CRDR,
          'amount' => $newdb{'lookup'}{'receipt'}{$row->{'ReceiptNum'}}{$row->{'PaymentType'}}{'amount'},
-         'comment' => "$_ Entry Receipt: $row->{'ReceiptNum'}; Type: $row->{'PaymentType'}",
+         #'comment' => "$_ Entry Receipt: $row->{'ReceiptNum'}; Type: $row->{'PaymentType'}",
              });
 
       $newdb{'lookup'}{'receipt'}{$row->{'ReceiptNum'}}{$row->{'PaymentType'}}{$_.'_entry_id'}
@@ -1250,7 +1250,7 @@ foreach $row (@{query($sdbh, $query)}) {
       
       'debit_entry_id' => $newdb{'lookup'}{'receipt'}{$row->{'ReceiptNum'}}{$row->{'PaymentType'}}{'debit_entry_id'},
       'credit_entry_id' => $newdb{'lookup'}{'receipt'}{$row->{'ReceiptNum'}}{$row->{'PaymentType'}}{'credit_entry_id'},
-      'comment' => "Double Entry: $row->{'ReceiptNum'}; Type: $row->{'PaymentType'}",
+      #'comment' => "Double Entry: $row->{'ReceiptNum'}; Type: $row->{'PaymentType'}",
           });
 
    $newdb{'lookup'}{'receipt'}{$row->{'ReceiptNum'}}{$row->{'PaymentType'}}{'double_entry_id'}
@@ -1262,7 +1262,7 @@ foreach $row (@{query($sdbh, $query)}) {
       'name'  => $newdb{'lookup'}{'receipt'}{$row->{'ReceiptNum'}}{$row->{'PaymentType'}}{'name'},
       'tender_type_id' => $newdb{'lookup'}{'receipt'}{$row->{'ReceiptNum'}}{$row->{'PaymentType'}}{'tender_type_id'},
       'data1' => $newdb{'lookup'}{'receipt'}{$row->{'ReceiptNum'}}{$row->{'PaymentType'}}{'data1'},
-      'comment' => "Physical Payment: $row->{'ReceiptNum'}; Type: $row->{'PaymentType'}",
+      #'comment' => "Physical Payment: $row->{'ReceiptNum'}; Type: $row->{'PaymentType'}",
           });
 
    $newdb{'lookup'}{'receipt'}{$row->{'ReceiptNum'}}{$row->{'PaymentType'}}{'tender_id'}
@@ -1329,8 +1329,9 @@ foreach $row (@{query($sdbh, $query)})
    ]{'customer_id'} = $newdb{'lookup'}{'payment'}{$row->{'PaymentID'}}{'customer_id'};
 
    # Use the Memo as our comment, if it exists
-   my $comment = $row->{'Memo'} || "Payment: $row->{'ReceiptNum'}; Type: $row->{'PaymentType'}";
+   my $comment = $row->{'Memo'}
-   $comment = "Payment: $row->{'ReceiptNum'}; Type: $row->{'PaymentType'}; Charge: $row->{'ChargeID'}";
+   #|| "Payment: $row->{'ReceiptNum'}; Type: $row->{'PaymentType'}; Charge: $row->{'ChargeID'}"
+   ;
 
    # Add the Payment Statement Entry
    addRow('statement_entries', {

todo.notes

@@ -60,6 +60,8 @@ both of these should be displayed on the Lease view page.
 
 Make the default (initial) jqGrid sort order for balance be DESC.
 
+20090729: New Ledger doesn't seem to give a balance forward entry.
+
 MUST reports:
  - Delinquent customers
  - Locked out units / customers