Finally added a format helper, which has been long intended. There may be still be conversion issues, it hasn't been tested much.

git-svn-id: file:///svn-source/pmgr/branches/ledger_transactions_20090605/site@77 97e9348a-65ac-dc4b-aefc-98561f571b83

views/elements/accounts.ctp

@@ -2,28 +2,17 @@
 
 if (isset($heading))
   echo $heading;
-else
+elseif (!isset($caption))
   echo '<h2>'.__('Accounts',true).'</h2>';
 
-function currency($number) {
-   if ($number < 0)
-     return "($ " . number_format(-1*$number, 2) . ")";
-   else
-     return "$ " . number_format($number, 2);
-}
-
-function datefmt($date) {
-  $date_fmt = 'm/d/Y';
-  return ($date
-	  ? date_format(date_create($date), $date_fmt)
-	  : null);
-}
-
 $headers = array('Name', 'Type', 'Ext. Name', 'Ext. Account', 'Entries', 'Debits', 'Credits', 'Balance', 'Comment');
 $column_class = array();
-foreach (array_intersect($column_class, array('Debits', 'Credits', 'Balance')) AS $k => $v) {
+foreach (array_intersect($headers, array('Debits', 'Credits', 'Balance')) AS $k => $v) {
   $column_class[$k] = 'currency';
 }
+foreach (array_intersect($headers, array('Comment')) AS $k => $v) {
+  $column_class[$k] = 'slack';
+}
 
 if (isset($paginator)) {
   echo $paginator->counter(array(
@@ -61,15 +50,16 @@ foreach ($accounts as $account) {
 		  $account['external_name'],
 		  $account['external_account'],
 		  $account['entries'],
-		  currency($account['debits']),
-		  currency($account['credits']),
-		  currency($account['balance']),
+		  FormatHelper::currency($account['debits']),
+		  FormatHelper::currency($account['credits']),
+		  FormatHelper::currency($account['balance']),
 		  $account['comment'],
 		  );
 }
 
 echo $this->element('table',
 		    array('class'   => 'item account list',
+			  'caption' => isset($caption) ? $caption : null,
 			  'headers' => $headers,
 			  'rows'    => $rows,
 			  'column_class' => $column_class));