Commit Graph

1462 Commits

Author SHA1 Message Date
abijah
d36cfd9653 Disabled logging again
git-svn-id: file:///svn-source/pmgr/branches/yafr_20090716@610 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-18 01:32:09 +00:00
abijah
2b8fa33f06 Added a column to Tender that identifies the exact ledger entry which was used to deposit the tender. It was necessary due to the kludgy way that I've set ACH items to auto-deposit, which uses a ledger entry that has nothing to do with the transaction account. This would probably allow us to eliminate the deposit_transaction_id, but I'd like to break as little as possible at the moment. I'll come back and clean this up in the future. Also, fixed a stupid bug that was causing major database thrash whenever a transaction was entered without a customer id. I could have fixed the Customer::update() function, but it was designed to accept null so that we could update all the customers, something definitely useful while developing.
git-svn-id: file:///svn-source/pmgr/branches/yafr_20090716/site@609 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-17 23:55:51 +00:00
abijah
d141f61055 Added a column to Tender that identifies the exact ledger entry which was used to deposit the tender. It was necessary due to the kludgy way that I've set ACH items to auto-deposit, which uses a ledger entry that has nothing to do with the transaction account. This would probably allow us to eliminate the deposit_transaction_id, but I'd like to break as little as possible at the moment. I'll come back and clean this up in the future. Also, fixed a stupid bug that was causing major database thrash whenever a transaction was entered without a customer id. I could have fixed the Customer::update() function, but it was designed to accept null so that we could update all the customers, something definitely useful while developing.
git-svn-id: file:///svn-source/pmgr/branches/yafr_20090716@609 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-17 23:55:51 +00:00
abijah
8167cc6a6a Added an assert whenever we lookup an account that doesn't exist.
git-svn-id: file:///svn-source/pmgr/branches/yafr_20090716/site@608 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-17 23:51:09 +00:00
abijah
4b8dc3da02 Added an assert whenever we lookup an account that doesn't exist.
git-svn-id: file:///svn-source/pmgr/branches/yafr_20090716@608 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-17 23:51:09 +00:00
abijah
1c82d55c1c First pass at making ACH items auto-deposit. Things are really set up for a separate deposit transaction though, and I should just bite the bullet and do that instead. I don't want them to show up as Deposits though, but perhaps it would be easiest just to make a new type 'AUTO_DEPOSIT' or something.
git-svn-id: file:///svn-source/pmgr/branches/yafr_20090716/site@607 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-17 21:16:16 +00:00
abijah
709689b15b First pass at making ACH items auto-deposit. Things are really set up for a separate deposit transaction though, and I should just bite the bullet and do that instead. I don't want them to show up as Deposits though, but perhaps it would be easiest just to make a new type 'AUTO_DEPOSIT' or something.
git-svn-id: file:///svn-source/pmgr/branches/yafr_20090716@607 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-17 21:16:16 +00:00
abijah
ff37597b81 Added a grid load error indication, since it was lost when we disabled the debug output.
git-svn-id: file:///svn-source/pmgr/branches/yafr_20090716/site@606 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-17 18:41:17 +00:00
abijah
3eb989e03c Added a grid load error indication, since it was lost when we disabled the debug output.
git-svn-id: file:///svn-source/pmgr/branches/yafr_20090716@606 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-17 18:41:17 +00:00
abijah
3ba1e8b97a Fixed a bug when transitioning to a move-in receipt, and changed the invoice/receipt grids to only contain current customers / active leases. A non-current customer or closed lease can still have a receipt/invoice, the user will just have to go directly to the customer / lease first. OK, so I just checked and that's not true. Perhaps it should be...
git-svn-id: file:///svn-source/pmgr/branches/yafr_20090716/site@605 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-17 17:23:50 +00:00
abijah
eb019dd9e5 Fixed a bug when transitioning to a move-in receipt, and changed the invoice/receipt grids to only contain current customers / active leases. A non-current customer or closed lease can still have a receipt/invoice, the user will just have to go directly to the customer / lease first. OK, so I just checked and that's not true. Perhaps it should be...
git-svn-id: file:///svn-source/pmgr/branches/yafr_20090716@605 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-17 17:23:50 +00:00
abijah
719373e534 Captured a couple more todo items
git-svn-id: file:///svn-source/pmgr/branches/yafr_20090716@604 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-17 17:07:24 +00:00
abijah
5abe0770b3 Modified the customer update() function to update all customers if passed null. This would not be a typcial scenario, but it useful at the moment during development.
git-svn-id: file:///svn-source/pmgr/branches/yafr_20090716/site@603 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-17 06:32:32 +00:00
abijah
1c5d97f06d Modified the customer update() function to update all customers if passed null. This would not be a typcial scenario, but it useful at the moment during development.
git-svn-id: file:///svn-source/pmgr/branches/yafr_20090716@603 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-17 06:32:32 +00:00
abijah
287d9f8f11 Fixed a bug with charge through / paid through, which was not taking into account reversed charges. I fear there are other conditions not being accounted for, not only here but throughout. One at a time for now...
git-svn-id: file:///svn-source/pmgr/branches/yafr_20090716/site@602 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-17 06:31:42 +00:00
abijah
589168440c Fixed a bug with charge through / paid through, which was not taking into account reversed charges. I fear there are other conditions not being accounted for, not only here but throughout. One at a time for now...
git-svn-id: file:///svn-source/pmgr/branches/yafr_20090716@602 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-17 06:31:42 +00:00
abijah
d3d5b54b39 Eliminated (at least temporarily) the single ledger entry view, redirecting to the double entry view instead.
git-svn-id: file:///svn-source/pmgr/branches/yafr_20090716/site@601 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-17 06:30:01 +00:00
abijah
73c5a20158 Eliminated (at least temporarily) the single ledger entry view, redirecting to the double entry view instead.
git-svn-id: file:///svn-source/pmgr/branches/yafr_20090716@601 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-17 06:30:01 +00:00
abijah
4f6f478a9a Hopeful fix for the bug affecting customer security deposit balance. It was introduced when we added the Customer Credit account, since Security Deposit no longer _directly_ pays charges like it used to. Now, it's converted to customer credit, and _that_ account is the one that pays. The security deposit situation is a bit shaky, but seems to be working again.
git-svn-id: file:///svn-source/pmgr/branches/yafr_20090716/site@600 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-17 05:48:54 +00:00
abijah
a44654ec01 Hopeful fix for the bug affecting customer security deposit balance. It was introduced when we added the Customer Credit account, since Security Deposit no longer _directly_ pays charges like it used to. Now, it's converted to customer credit, and _that_ account is the one that pays. The security deposit situation is a bit shaky, but seems to be working again.
git-svn-id: file:///svn-source/pmgr/branches/yafr_20090716@600 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-17 05:48:54 +00:00
abijah
b8d0e18014 Fixed bug when fetching data for editing a customer (the details function was deleted sometime back and might be worth putting back in). Also, added a tiny helper feature to update cached items while things are still somewhat unstable. Any time customer edit is clicked, the customer (and associated leases) will all be updated. This should allow an easy customer workaround in case there is a bug in the field.
git-svn-id: file:///svn-source/pmgr/branches/yafr_20090716/site@599 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-17 05:43:01 +00:00
abijah
7a331d5f4f Fixed bug when fetching data for editing a customer (the details function was deleted sometime back and might be worth putting back in). Also, added a tiny helper feature to update cached items while things are still somewhat unstable. Any time customer edit is clicked, the customer (and associated leases) will all be updated. This should allow an easy customer workaround in case there is a bug in the field.
git-svn-id: file:///svn-source/pmgr/branches/yafr_20090716@599 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-17 05:43:01 +00:00
abijah
4c44794212 Added confirmation page, and more importantly date and comment settings, when reversing a charge.
git-svn-id: file:///svn-source/pmgr/branches/yafr_20090716/site@598 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-17 05:37:29 +00:00
abijah
daf9fe9391 Added confirmation page, and more importantly date and comment settings, when reversing a charge.
git-svn-id: file:///svn-source/pmgr/branches/yafr_20090716@598 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-17 05:37:29 +00:00
abijah
a167b8a885 Added code to make jqGrid development aware
git-svn-id: file:///svn-source/pmgr/branches/yafr_20090716/site@597 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-17 03:44:09 +00:00
abijah
d8767cfb73 Added code to make jqGrid development aware
git-svn-id: file:///svn-source/pmgr/branches/yafr_20090716@597 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-17 03:44:09 +00:00
abijah
18d384ecb3 Merge in support for jqGrid 3.5 (plus a change to layout.css after the merge).
git-svn-id: file:///svn-source/pmgr/branches/yafr_20090716/site@596 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-17 03:39:29 +00:00
abijah
64792e6fe2 Merge in support for jqGrid 3.5 (plus a change to layout.css after the merge).
git-svn-id: file:///svn-source/pmgr/branches/yafr_20090716@596 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-17 03:39:29 +00:00
abijah
77db0c2ed9 Fixed the test for delinquency from 15 days (used while debugging) to 10 days
git-svn-id: file:///svn-source/pmgr/branches/yafr_20090716/site@595 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-17 03:38:07 +00:00
abijah
424276eeb4 Fixed the test for delinquency from 15 days (used while debugging) to 10 days
git-svn-id: file:///svn-source/pmgr/branches/yafr_20090716@595 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-17 03:38:07 +00:00
abijah
ebd80a8313 Turned off debugging code that was left on.
git-svn-id: file:///svn-source/pmgr/branches/yafr_20090716/site@594 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-17 02:52:47 +00:00
abijah
377a4cc88c Turned off debugging code that was left on.
git-svn-id: file:///svn-source/pmgr/branches/yafr_20090716@594 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-17 02:52:47 +00:00
abijah
23cdd0e497 Merge in from surplus_account_20090815 r592
git-svn-id: file:///svn-source/pmgr/branches/yafr_20090716/site@593 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-17 02:22:54 +00:00
abijah
170f660528 Merge in from surplus_account_20090815 r592
git-svn-id: file:///svn-source/pmgr/branches/yafr_20090716@593 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-17 02:22:54 +00:00
abijah
90ecbda541 Several minor changes including a couple minor bugfixes.
git-svn-id: file:///svn-source/pmgr/branches/surplus_account_20090815@592 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-17 02:15:02 +00:00
abijah
4afe0bd77b Added logic to prevent a double entry where the credit and debit record in the exact same ledger. There is no known reason why we would need to record such an entry, even though it would not be incorrect to do so.
git-svn-id: file:///svn-source/pmgr/branches/surplus_account_20090815@591 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-16 23:41:44 +00:00
abijah
8440a7c833 Checkin a support function that is needed by the Transaction model since several checkins ago.
git-svn-id: file:///svn-source/pmgr/branches/surplus_account_20090815@590 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-16 22:51:08 +00:00
abijah
00d509f23d Minor formatting issue for the Transaction.type enums
git-svn-id: file:///svn-source/pmgr/branches/surplus_account_20090815@589 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-16 22:48:00 +00:00
abijah
080c82fc10 More bug fixes, especially around reversals of charges that have been paid from something other than customer money (such as waivers). I suspect it still will not work correctly for concession, depending on your point of view. Either concession should not count as customer credit, since they never paid that money, or it should since they were told they would get $X off, and upon charge reversal, they no longer get the credit. It seems they would only get the credit when reversing a mistaken charge, in which case, the user can manually provide a new concession.
git-svn-id: file:///svn-source/pmgr/branches/surplus_account_20090815@588 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-16 22:35:02 +00:00
abijah
1b02be19f0 Adjusted to match the naming in the database
git-svn-id: file:///svn-source/pmgr/branches/surplus_account_20090815@587 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-16 22:31:06 +00:00
abijah
366d59a5e6 Added a customer credit account.
git-svn-id: file:///svn-source/pmgr/branches/surplus_account_20090815@586 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-16 19:16:42 +00:00
abijah
2634cf824a Another checkin screwup where we accidentally specified ledger.php instead of ledger_entry.php
git-svn-id: file:///svn-source/pmgr/branches/surplus_account_20090815@585 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-16 19:14:37 +00:00
abijah
1429fe720b Added mechanism to lookup the NSF tender from the bounce transaction.
git-svn-id: file:///svn-source/pmgr/branches/surplus_account_20090815@584 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-16 19:00:45 +00:00
abijah
754cdb8522 Fixed bug with NSF, which was failing to locate the nsf_entry_id. To resolve this, I added the original data into the return structure for each item, instead of just the created IDs. Also, added NsfTender to the Transaction model to locate which Tender an NSF transaction relates to.
git-svn-id: file:///svn-source/pmgr/branches/surplus_account_20090815@583 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-16 18:59:16 +00:00
abijah
a1a68f3209 Updated SQL scratchpad
git-svn-id: file:///svn-source/pmgr/branches/surplus_account_20090815@582 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-16 16:48:44 +00:00
abijah
8843d24baa Added SQL scratchpad
git-svn-id: file:///svn-source/pmgr/branches/surplus_account_20090815@581 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-16 16:37:54 +00:00
abijah
892618db36 I need to check again in the morning, but it seem like this is finally what we need for reversals. Of course, we're still using A/P as a temporary solution. If we do indeed move forward with this sort of solution (dedicated customer credit account), then we'll have to create a new account fairly soon.
git-svn-id: file:///svn-source/pmgr/branches/surplus_account_20090815@580 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-16 09:31:19 +00:00
abijah
3decfff33b Fixed is_bool / is_boolean bug
git-svn-id: file:///svn-source/pmgr/branches/surplus_account_20090815@579 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-16 06:12:46 +00:00
abijah
945221d565 Changed reversals to create an explicit credit BEFORE assigning credits to outstanding charges. This ensures that charges are paid from the customer surplus account and we don't end up with bizarre disbursements, like having Rent paid from Damage or whatever the reversed charge was.
git-svn-id: file:///svn-source/pmgr/branches/surplus_account_20090815@578 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-16 05:17:09 +00:00
abijah
a968d7abe6 Changed the explicit receipt amount to be driven from stats instead of the assignCredits return value. This is in anticipation of creating an explicit credit directly, without even calling assignCredits. I'll do that for reversal on the next checkin.
git-svn-id: file:///svn-source/pmgr/branches/surplus_account_20090815@577 97e9348a-65ac-dc4b-aefc-98561f571b83
2009-08-16 04:43:34 +00:00