property_manager database backup as of 2010_02_27_0124

git-svn-id: file:///svn-source/pmgr/tags/v0.1.0@935 97e9348a-65ac-dc4b-aefc-98561f571b83

requirements.txt

@@ -45,7 +45,7 @@ Operations to be functional
  X - Receive and record Money Orders
  X - Receive and record Cash
  X - Receive and record ACH Deposits
- ? - Reverse rent charges (early moveout on prepaid occupancy)
+ X - Reverse rent charges (early moveout on prepaid occupancy)
  X - Handle NSF checks
  X - Assess NSF Fees
  X - Determine Lease Paid-Through status

site/app_controller.php

@@ -220,10 +220,6 @@ class AppController extends Controller {
     $this->addSideMenuLink('Stmt Entries',
 			   array('controller' => 'statement_entries', 'action' => 'index'), null,
 			   'SITE', $this->admin_area);
-    $this->addSideMenuLink('Assess Charges',
-			   array('controller' => 'leases', 'action' => 'assess_all'), null,
-			   'SITE', $this->admin_area);
-
 
     $this->addSideMenuLink('Un-Nuke',
 			   '#', array('htmlAttributes' =>
@@ -250,6 +246,10 @@ class AppController extends Controller {
     $this->addSideMenuLink('New Deposit',
 			   array('controller' => 'tenders', 'action' => 'deposit'), null,
 			   'SITE', $this->op_area);
+    if (!empty($this->params['admin']))
+      $this->addSideMenuLink('Assess Charges',
+			     array('controller' => 'leases', 'action' => 'assess_all'), null,
+			     'SITE', $this->op_area);
 
     $url_components = array('plugin', 'controller', 'action', 'named');
     if (devbox()) {

site/controllers/leases_controller.php

@@ -394,6 +394,10 @@ class LeasesController extends AppController {
     $this->set(compact('default_late'));
 
     if ($type === 'move-in') {
+      // Make sure we have a valid lease that we're moving in
+      if (empty($lease))
+	$this->redirect(array('action' => 'index'));
+
       $movein = array();
       $movein['time'] = strtotime($lease['Lease']['movein_date']);
       $movein['effective_time'] = strtotime($lease['Lease']['movein_date']);

site/controllers/transactions_controller.php

@@ -112,7 +112,7 @@ class TransactionsController extends AppController {
    *  - handles the creation of a charge invoice
    */
 
-  function postInvoice() {
+  function postInvoice($redirect = true) {
     if (!$this->RequestHandler->isPost()) {
       echo('<H2>THIS IS NOT A POST FOR SOME REASON</H2>');
       return;
@@ -127,6 +127,17 @@ class TransactionsController extends AppController {
       die("<H1>INVOICE FAILED</H1>");
     }
 
+    if ($redirect) {
+      if (!empty($this->data['Customer']['id']))
+	$this->redirect(array('controller' => 'customers',
+			      'action'     => 'receipt',
+			      $this->data['Customer']['id']));
+      else
+	$this->redirect(array('controller' => 'leases',
+			      'action'     => 'view',
+			      $this->data['Lease']['id']));
+    }
+
     $this->layout = null;
     $this->autoLayout = false;
     $this->autoRender = false; 
@@ -140,7 +151,7 @@ class TransactionsController extends AppController {
    *  - handles the creation of a receipt
    */
 
-  function postReceipt() {
+  function postReceipt($redirect = true) {
     if (!$this->RequestHandler->isPost()) {
       echo('<H2>THIS IS NOT A POST FOR SOME REASON</H2>');
       return;
@@ -164,6 +175,11 @@ class TransactionsController extends AppController {
       die("<H1>RECEIPT FAILED</H1>");
     }
 
+    if ($redirect)
+      $this->redirect(array('controller' => 'customers',
+			    'action'     => 'view',
+			    $this->data['Customer']['id']));
+
     $this->layout = null;
     $this->autoLayout = false;
     $this->autoRender = false; 
@@ -377,9 +393,11 @@ class TransactionsController extends AppController {
    *    irreversibly destroys the data.  It is not for normal use.
    */
 
-  function destroy($id = null) {
+  function destroy($id) {
+    $this->Transaction->id = $id;
+    $customer_id = $this->Transaction->field('customer_id');
     $this->Transaction->destroy($id);
-    //$this->redirect(array('action' => 'index'));
+    $this->redirect(array('controller' => 'customers', 'action' => 'view', $customer_id));
   }
 
 
@@ -423,7 +441,7 @@ class TransactionsController extends AppController {
 				 "This may leave the database in an unstable state." .
 				 " Do NOT do this unless you know what you're doing." .
 				 " Proceed anyway?"),
-			   'ACTION', $this->dev_area);
+			   'ACTION', $this->admin_area);
 
     // OK, prepare to render.
     $title = 'Transaction #' . $transaction['Transaction']['id'];

site/controllers/util_controller.php

@@ -62,4 +62,15 @@ class UtilController extends AppController {
   function rebuild_sandbox() { $this->rebuild_box('sand'); }
   function rebuild_devbox()  { $this->rebuild_box('dev'); }
 
+
+  /**************************************************************************
+   **************************************************************************
+   **************************************************************************
+   * function: logmsg
+   *  - action to allow posting log message data
+   */
+
+  function logmsg() {
+  }
+  
 }

site/models/customer.php

@@ -247,10 +247,10 @@ class Customer extends AppModel {
       return;
     }
 
-    // REVISIT <AP>: 20090812
-    //  updateLeaseCount is handled directly when needed.
-    //  Should we simplify by just doing it anyway?
-    //$this->updateLeaseCount($id);
+    // updateLeaseCount is typically handled directly when needed.
+    // However, this function is used to _ensure_ customer info is
+    // current, so we're obligated to call it anyway.
+    $this->updateLeaseCount($id);
 
     $current_leases =
       $this->find('all',

site/views/customers/receipt.ctp

@@ -25,12 +25,12 @@ Configure::write('debug', '0');
       beforeSubmit:  verifyRequest,  // pre-submit callback 
       success:       showResponse,  // post-submit callback 
  
-      url: "<?php echo $html->url(array('controller' => 'transactions',
-					'action' => 'postReceipt', 0)); ?>",
- 
       // other available options: 
       //clearForm: true,        // clear all form fields after successful submit 
       //resetForm: true,        // reset the form after successful submit 
+
+      url: "<?php echo $html->url(array('controller' => 'transactions',
+					'action' => 'postReceipt', 0)); ?>"
       }; 
 
     // bind form using 'ajaxForm' 

site/views/elements/sidemenu.ctp

@@ -74,9 +74,9 @@ jQuery(document).ready(function(){
       jQuery("#sidemenu").accordion
 	({  fillSpace : true,
 	    event : "click hoverintent",
-	    animated : "bounceslide",
+	    animated : "bounceslide"
 JSCB
-. (isset($active_section) ? "\tactive : $active_section,\n" : '') .
+. (isset($active_section) ? ",\n\t    active : $active_section\n" : '') .
 <<<JSCB
 	});
     }

site/views/layouts/default.ctp

@@ -86,6 +86,18 @@
 		echo $javascript->link('pmgr') . "\n";
 		echo $scripts_for_layout . "\n";
 	?>
+
+	<?php if ($this->params['action'] !== 'INTERNAL_ERROR'): ?>
+	<script type="text/javascript"><!--
+	if (typeof(jQuery) == 'undefined') {
+		window.location.href =
+			"<?php echo $html->url(array('controller' => 'util',
+			                   'action'     => 'INTERNAL_ERROR',
+	                                   'jQuery NOT LOADED!')); ?>";
+	}
+	--></script>
+	<?php endif; ?>
+
 </head>
 <body>
 

site/views/leases/invoice.ctp

@@ -27,33 +27,24 @@ Configure::write('debug', '0');
 
   // prepare the form when the DOM is ready 
   $(document).ready(function() { 
-      $("#debug").append('doc ready1' + '<BR>');
-      var options = { 
+    var options = { 
       target:        '#output-debug',   // target element(s) to be updated with server response 
       beforeSubmit:  verifyRequest,  // pre-submit callback 
       success:       showResponse,  // post-submit callback 
 
-      url: "<?php echo $html->url(array('controller' => 'transactions',
-					'action' => 'postInvoice', 0)); ?>",
- 
       // other available options: 
       //clearForm: true,        // clear all form fields after successful submit 
       //resetForm: true,        // reset the form after successful submit 
+
+      url: "<?php echo $html->url(array('controller' => 'transactions',
+					'action' => 'postInvoice', 0)); ?>"
       };
 
-      if ($('#invoice-form').ajaxForm != null) 
-	$("#debug").append('ajax present' + '<BR>');
-      else
-	$("#debug").append('ajax not present' + '<BR>');
-
-      // bind form using 'ajaxForm' 
-      if ($('#invoice-form').ajaxForm != null) {
-	$("#debug").append('go ajax' + '<BR>');
-	$('#invoice-form').ajaxForm(options); 
-	$("#debug").append('ajax set' + '<BR>');
-      }
-      else
-	$('#repeat, label[for=repeat]').remove();
+    // bind form using 'ajaxForm' 
+    if ($('#invoice-form').ajaxForm != null)
+      $('#invoice-form').ajaxForm(options); 
+    else
+      $('#repeat, label[for=repeat]').remove();
     });
  
 // pre-submit callback 
@@ -131,13 +122,11 @@ function showResponse(responseText, statusText)  {
 
 // Reset the form
 function resetForm(nocharge) {
-  $("#debug").append('reset form: ' + nocharge + '<BR>');
   $('#charge-entry-id').val(1);
   $('#charges').html('');
 
   if (!nocharge)
     addChargeSource(false);
-  $("#debug").append('reset form done' + '<BR>');
 }
 
 
@@ -163,7 +152,6 @@ function onRowSelect(grid_id, lease_id) {
 }
 
 function onGridState(grid_id, state) {
-  $("#debug").append('on grid state: ' + grid_id + '; ' + state + '<BR>');
   if (state == 'visible') {
     $(".lease-selection-invalid").hide();
     $(".lease-selection-valid").hide();
@@ -177,11 +165,9 @@ function onGridState(grid_id, state) {
       $(".lease-selection-invalid").show();
     }
   }
-  $("#debug").append('on grid state done' + '<BR>');
 }
 
 function addChargeSource(flash) {
-  $("#debug").append('add charge source' + '<BR>');
   var id = $("#charge-entry-id").val();
   addDiv('charge-entry-id', 'charge', 'charges', flash,
 	 // HTML section
@@ -218,14 +204,10 @@ function addChargeSource(flash) {
 
 	 '</FIELDSET>'
 	 );
-  $("#debug").append('add div complete' + '<BR>');
 
-  $("#debug").append('add datepicker1' + '<BR>');
   datepicker("Entry"+id+"EffectiveDate");
-  $("#debug").append('add datepicker2' + '<BR>');
   datepicker("Entry"+id+"ThroughDate");
 
-  $("#debug").append('add charge source complete' + '<BR>');
   return id;
   }
 
@@ -349,7 +331,6 @@ Configure::write('debug', '0');
   };
 
   $(document).ready(function(){
-      $("#debug").append('doc ready2' + '<BR>');
       datepicker('TransactionStamp');
 
       $("#lease-id").val(0);
@@ -362,13 +343,11 @@ Configure::write('debug', '0');
 
       <?php if (empty($movein)): ?>
 
-      $("#debug").append('movein empty' + '<BR>');
       resetForm();
       datepickerNow('TransactionStamp');
 
       <?php else: ?>
 
-      $("#debug").append('movein not empty' + '<BR>');
       var id;
       resetForm(true);
 

site/views/maps/view.ctp

@@ -6,6 +6,19 @@
  {// for indentation purposes
    // Go through each unit, adding a clickable region for the unit
    foreach ($info['units'] AS $unit){
+     $title = ('Unit #' .
+	       $unit['name'] .
+	       (empty($unit['data']['CurrentLease']['id'])
+		? ''
+		: ('; ' .
+		   /* 	      'Lease #' . */
+		   /* 	      $unit['data']['CurrentLease']['id'] . */
+		   /* 	      '; ' . */
+		   $unit['data']['Customer']['name'] .
+		   '; Paid Through ' .
+		   $unit['data']['CurrentLease']['paid_through_date'])
+		));
+
      echo('    <area shape="rect"' .
 	  ' coords="' .
 	  $unit['left']   . ',' .
@@ -16,20 +29,8 @@
 	  $html->url(array('controller' => 'units',
 			   'action'     => 'view',
 			   $unit['id'])) .
-	  '" alt="Unit #' .
-	  $unit['name'] .
-	  '" title="Unit #' .
-	  $unit['name'] .
-	  (empty($unit['data']['CurrentLease']['id'])
-	   ? ''
-	   : ('; ' .
-/* 	      'Lease #' . */
-/* 	      $unit['data']['CurrentLease']['id'] . */
-/* 	      '; ' . */
-	      $unit['data']['Customer']['name'] .
-	      '; Paid Through ' .
-	      $unit['data']['CurrentLease']['paid_through_date'])
-	   ) .
+	  '" alt="' . $title .
+	  '" title="' . $title .
 	  '">' . "\n");
    }
  }// for indentation purposes

todo.notes

@@ -1,3 +1,36 @@
+When performing a move-in, the receipt page is broken
+when trying to enter a concession. javascript complains about
+an invalid value, and the page is not submitted.
+ - Allegedly.  I believe Shirley's browser was acting up
+   on her, and based on the logs, it seems that indeed
+   what ultimately worked just fine for a concession entry
+   was really the exact same page that was stuck.  While
+   on the phone it was evident that here browser was
+   doing a javascript wig-out, and it wasn't related to
+   a slow internet connection.
+   
+
+Reversing a rent charge is not considered as part of the
+"charged-through" date on the lease.  Consequently, the
+reversal itself ensures the charge is fully "paid", and
+the "paid-through" date is also out of whack.
+
+Add invoice rent helpers
+ - monthly proration tool
+   - select from/to dates, and hit "prorate"
+ - charge through date
+   - enter charge through date, and the invoice
+     will automatically have charges for each month
+     from the current charge-through date to the
+     new charge-through date.
+ - charge N months
+   - enter number of months, and the invoice
+     will automatically have charges for each month
+     from the current charge-through date for N months
+ - next rent
+   - same as, or instead of, "charge N months", where
+     N is 1
+
 Add NSF Fee to the NSF entry page (It's hardcoded right now
 in Transaction to $35).
 
@@ -52,11 +85,6 @@ Reduce the number of cached items.  Figure out how to get Cake to
 automatically make CONCAT(TenderType.name, ' #', Tender.id) part
 of each returned query.
 
-Implement, as part of the User model, a function to return the
-security level.  Have it be a static function, so that we don't
-need to instantiate it, and right now, return a level based on
-the route.
-
 Add the opposite of the "collected" report, which provides a set of
 checkboxes for the different incomes, and returns a list of where
 the received monies were disbursed for the selected period.