4afe0bd77b
Added logic to prevent a double entry where the credit and debit record in the exact same ledger. There is no known reason why we would need to record such an entry, even though it would not be incorrect to do so.
abijah
2009-08-16 23:41:44 +00:00
8440a7c833
Checkin a support function that is needed by the Transaction model since several checkins ago.
abijah
2009-08-16 22:51:08 +00:00
00d509f23d
Minor formatting issue for the Transaction.type enums
abijah
2009-08-16 22:48:00 +00:00
080c82fc10
More bug fixes, especially around reversals of charges that have been paid from something other than customer money (such as waivers). I suspect it still will not work correctly for concession, depending on your point of view. Either concession should not count as customer credit, since they never paid that money, or it should since they were told they would get $X off, and upon charge reversal, they no longer get the credit. It seems they would only get the credit when reversing a mistaken charge, in which case, the user can manually provide a new concession.
abijah
2009-08-16 22:35:02 +00:00
1b02be19f0
Adjusted to match the naming in the database
abijah
2009-08-16 22:31:06 +00:00
366d59a5e6
Added a customer credit account.
abijah
2009-08-16 19:16:42 +00:00
2634cf824a
Another checkin screwup where we accidentally specified ledger.php instead of ledger_entry.php
abijah
2009-08-16 19:14:37 +00:00
1429fe720b
Added mechanism to lookup the NSF tender from the bounce transaction.
abijah
2009-08-16 19:00:45 +00:00
754cdb8522
Fixed bug with NSF, which was failing to locate the nsf_entry_id. To resolve this, I added the original data into the return structure for each item, instead of just the created IDs. Also, added NsfTender to the Transaction model to locate which Tender an NSF transaction relates to.
abijah
2009-08-16 18:59:16 +00:00
892618db36
I need to check again in the morning, but it seem like this is finally what we need for reversals. Of course, we're still using A/P as a temporary solution. If we do indeed move forward with this sort of solution (dedicated customer credit account), then we'll have to create a new account fairly soon.
abijah
2009-08-16 09:31:19 +00:00
945221d565
Changed reversals to create an explicit credit BEFORE assigning credits to outstanding charges. This ensures that charges are paid from the customer surplus account and we don't end up with bizarre disbursements, like having Rent paid from Damage or whatever the reversed charge was.
abijah
2009-08-16 05:17:09 +00:00
a968d7abe6
Changed the explicit receipt amount to be driven from stats instead of the assignCredits return value. This is in anticipation of creating an explicit credit directly, without even calling assignCredits. I'll do that for reversal on the next checkin.
abijah
2009-08-16 04:43:34 +00:00
8b6b8884f7
More good progress on reversals. There is still an issue where after reversing, a disbursement can be applied to a new charge from the old charge account, instead of the surplus account. I'll work on that next.
abijah
2009-08-16 03:56:36 +00:00
14805190fc
Added back in the logic to simply update an existing explicit credit instead of creating an additional one. At the moment, I can't think of a scenario for this other than when reversing charges, which is still broken. So, until I make progress on that, it's not even clear this changes is needed, let alone whether it works.
abijah
2009-08-16 02:22:45 +00:00
a1bdecfcaa
More tweaks to the addTransaction algorithm, working on a solid plan for customer surplus
abijah
2009-08-16 02:04:13 +00:00
4896834a96
Added the account back into the grid, since an invoice could have charges across several accounts.
abijah
2009-08-16 01:06:14 +00:00
a9c3c40053
Bug fix for matching ledger entry to double entry
abijah
2009-08-16 00:49:21 +00:00
4125d7ba16
Quick and dirty hack to get double entries to show again.
abijah
2009-08-16 00:45:11 +00:00
26d9b1bc38
Modified the charges list on the receipt page to have the query performed directly as part of returning the grid data, instead of an intermediary call to get the unreconciled entries first. This not only ensures consistent data, but is quicker, cleaner, and fixes the customer balance bug that seems to have been introduced as part of the change to how customer surplus is handled (although it could have been resolved using the old technique just as well).
abijah
2009-08-15 23:04:57 +00:00
f30e536e47
Modified to automatically calculate the crdr field, if not specified
abijah
2009-08-15 20:43:00 +00:00
96a030e340
First pass changes for a dedicated customer credit account. This checkin is just refactoring.
abijah
2009-08-15 19:50:31 +00:00
460e9a2e64
Branch to experiment with keeping all customer surplus items in a dedicated liability account.
abijah
2009-08-15 19:48:30 +00:00
893fc74c0a
A couple bugfixes and some more tweaks to how reversals are handled.
abijah
2009-08-15 16:47:55 +00:00
6e63365604
A couple bugfixes and some more tweaks to how reversals are handled.
abijah
2009-08-15 16:47:55 +00:00
e76ad897a4
Getting closer on the reversal issue. There is definitely more testing to do, and some tweaks as well, but this may be approximately what we will finally settle on.
abijah
2009-08-15 03:11:16 +00:00
4f85dc243e
Getting closer on the reversal issue. There is definitely more testing to do, and some tweaks as well, but this may be approximately what we will finally settle on.
abijah
2009-08-15 03:11:16 +00:00
d40f43c617
Cleaned up several places regarding redirect and rendering during development for debug purposes. Also, added a link to the intended redirect target when we've rendered instead. These changes haven't been tested, hopefully they are benign.
abijah
2009-08-14 21:49:42 +00:00
170ba466de
Cleaned up several places regarding redirect and rendering during development for debug purposes. Also, added a link to the intended redirect target when we've rendered instead. These changes haven't been tested, hopefully they are benign.
abijah
2009-08-14 21:49:42 +00:00
ac6a830d27
Change to how reversals are handled. In the process, I've tried to solidify _exactly_ what addTransaction will do, since it was becoming a house of cards of sorts. It was using special logic to decide things like whether to add ledger entries, statement entries, or both, whether to assignCredits afterwards, whether the generated receipt was to be considered a credit, and so on. Consequently, modifications to any calling function (addInvoice, addWaiver, etc) would often require addTransaction modifications, which would turn around and break all of the other calling functions. So, that embedded logic has been removed from addTransaction, and the rules of what addTransaction should do are now defined by the callers. This change is DEFINTELY not complete, as it probably has several bugs, and it DOES NOT YET WORK for reversals. I need a clean baseline to move forward from though, and this checkin approximates where we need to go.
abijah
2009-08-14 21:31:56 +00:00
d2d1bb3fc4
Change to how reversals are handled. In the process, I've tried to solidify _exactly_ what addTransaction will do, since it was becoming a house of cards of sorts. It was using special logic to decide things like whether to add ledger entries, statement entries, or both, whether to assignCredits afterwards, whether the generated receipt was to be considered a credit, and so on. Consequently, modifications to any calling function (addInvoice, addWaiver, etc) would often require addTransaction modifications, which would turn around and break all of the other calling functions. So, that embedded logic has been removed from addTransaction, and the rules of what addTransaction should do are now defined by the callers. This change is DEFINTELY not complete, as it probably has several bugs, and it DOES NOT YET WORK for reversals. I need a clean baseline to move forward from though, and this checkin approximates where we need to go.
abijah
2009-08-14 21:31:56 +00:00
83e552211f
Moved the INTERNAL_ERROR calls to use the class function instead of the global one.
abijah
2009-08-14 21:21:21 +00:00
d024d333d2
Moved the INTERNAL_ERROR calls to use the class function instead of the global one.
abijah
2009-08-14 21:21:21 +00:00
fe1b0626c2
Modified INTERNAL_ERROR to support inclusion of the blank layout, since all the javascript is lost otherwise. This should only matter for development. Also, fixed a bug with rendering when redirect is called but headers have already been output.
abijah
2009-08-14 21:10:16 +00:00
778bb43895
Modified INTERNAL_ERROR to support inclusion of the blank layout, since all the javascript is lost otherwise. This should only matter for development. Also, fixed a bug with rendering when redirect is called but headers have already been output.
abijah
2009-08-14 21:10:16 +00:00
68df688f12
Minor tweak to grid caption and display of the entry id instead of the transaction id.
abijah
2009-08-14 21:07:50 +00:00
41321481c7
Minor tweak to grid caption and display of the entry id instead of the transaction id.
abijah
2009-08-14 21:07:50 +00:00
61a00f475a
Allow the dollar sign in the input box, since it will get stripped off later anyway.
abijah
2009-08-14 21:07:02 +00:00
fe9f6ce949
Allow the dollar sign in the input box, since it will get stripped off later anyway.
abijah
2009-08-14 21:07:02 +00:00
0c3f4c3e18
Fixed the currency function to always return in dollar amounts, and never in just cents, as the core currency function does.
abijah
2009-08-14 21:06:17 +00:00
f81bfdecc2
Fixed the currency function to always return in dollar amounts, and never in just cents, as the core currency function does.
abijah
2009-08-14 21:06:17 +00:00
90bf9bac0a
Fixed url generation since it was not propogating the admin/dev routing items. Also modified the invoice at move in to exclude the customer list, and to transition directly to the receipt page afterwards.
abijah
2009-08-14 21:05:36 +00:00
8dd6fc957d
Fixed url generation since it was not propogating the admin/dev routing items. Also modified the invoice at move in to exclude the customer list, and to transition directly to the receipt page afterwards.
abijah
2009-08-14 21:05:36 +00:00
4472a124f5
Dropped the security level for viewing statement and ledger entries
abijah
2009-08-14 21:01:25 +00:00
d92acf12de
Dropped the security level for viewing statement and ledger entries
abijah
2009-08-14 21:01:25 +00:00
09e44995f3
Fixed bug with statement entry counts when statement_entry_id is set
abijah
2009-08-14 21:00:21 +00:00
43d1d2ccf5
Fixed bug with statement entry counts when statement_entry_id is set
abijah
2009-08-14 21:00:21 +00:00
e42c83c585
Added support for deleting (destroying) a transaction. This is strictly development/super-admin type functionality.
abijah
2009-08-14 20:58:50 +00:00
c06399cf86
Added support for deleting (destroying) a transaction. This is strictly development/super-admin type functionality.
abijah
2009-08-14 20:58:50 +00:00
c31c3a3cdc
Added the http request to the internal error box, since it will be necessary to help track down any reported errors.
abijah
2009-08-14 18:13:12 +00:00
d1187f9bdd
Added the http request to the internal error box, since it will be necessary to help track down any reported errors.
abijah
2009-08-14 18:13:12 +00:00
469962dd40
Fixed a couple URL problems, including redirect, which was previously entirely unable to utilize our AppHelper for the url generation. Added a couple menu items into the Admin section. Changed debug to be OFF for any route other than the 'dev' one.
abijah
2009-08-14 18:11:33 +00:00
b7a77757f9
Fixed a couple URL problems, including redirect, which was previously entirely unable to utilize our AppHelper for the url generation. Added a couple menu items into the Admin section. Changed debug to be OFF for any route other than the 'dev' one.
abijah
2009-08-14 18:11:33 +00:00
4d0108c6f8
Fixed the datetime bug
abijah
2009-08-13 22:23:45 +00:00
5f199d97fe
Fixed the datetime bug
abijah
2009-08-13 22:23:45 +00:00
f1d852aea6
Moved paid-through from the detail box, which is semi-static information, to the info box, which holds data that changes with time (i.e. the so called pertinent information).
abijah
2009-08-13 22:09:27 +00:00
fc292e3366
Moved paid-through from the detail box, which is semi-static information, to the info box, which holds data that changes with time (i.e. the so called pertinent information).
abijah
2009-08-13 22:09:27 +00:00
8f6dd40b9a
Modified the formatted date/age results to be span encapsulated for later css formatting.
abijah
2009-08-13 22:08:43 +00:00
94e300a129
Modified the formatted date/age results to be span encapsulated for later css formatting.
abijah
2009-08-13 22:08:43 +00:00
1fee7646b6
Got rid of LATE as a unit status, as it did not represent an physical condition. The logic was moved to Lease, where it is a much better fit. The sitemap still presents LATE units, as it is a useful view, but the underlying logic is driven from Lease, not Unit. This checkin also includes a small feature change to how late charges are assessed, as well as a menu item to kick off the charge assessments (both accidentally wedged in to this changeset).
abijah
2009-08-13 20:55:19 +00:00
791b2d8ab1
Got rid of LATE as a unit status, as it did not represent an physical condition. The logic was moved to Lease, where it is a much better fit. The sitemap still presents LATE units, as it is a useful view, but the underlying logic is driven from Lease, not Unit. This checkin also includes a small feature change to how late charges are assessed, as well as a menu item to kick off the charge assessments (both accidentally wedged in to this changeset).
abijah
2009-08-13 20:55:19 +00:00
97d16bd712
Changed the default of the debug flag when generating grid data. The original intention was to have it debug by default, so that debugging would be on if the url were manually typed in. That has never been needed though, and this change not only results in cleaner logic, it makes sure we have no issues with routing.
abijah
2009-08-13 20:07:49 +00:00
091920d80a
Changed the default of the debug flag when generating grid data. The original intention was to have it debug by default, so that debugging would be on if the url were manually typed in. That has never been needed though, and this change not only results in cleaner logic, it makes sure we have no issues with routing.
abijah
2009-08-13 20:07:49 +00:00
9d716532bb
Changed the custom route variables, so that the dev route could set the admin flag and not screw up the routing. The AppController now checks the routing params to set the dev/admin flags.
abijah
2009-08-13 16:43:07 +00:00
1511986ed0
Changed the custom route variables, so that the dev route could set the admin flag and not screw up the routing. The AppController now checks the routing params to set the dev/admin flags.
abijah
2009-08-13 16:43:07 +00:00
4be4224742
Added admin and development routes, which should help while in transition to user security.
abijah
2009-08-13 16:09:45 +00:00
1e88e1fce2
Added admin and development routes, which should help while in transition to user security.
abijah
2009-08-13 16:09:45 +00:00
b741bb6b01
Added cached fields for charged_through and paid_through dates of a lease. Also, added the ability to dynamically determine whether a unit is late or not. In reality, we really need this to be part of the lease, not one of the status types for unit. The sitemap, however, is driven from unit information, so it's not clear whether we should move that information or not.
abijah
2009-08-13 02:37:37 +00:00
a2014a916e
Added cached fields for charged_through and paid_through dates of a lease. Also, added the ability to dynamically determine whether a unit is late or not. In reality, we really need this to be part of the lease, not one of the status types for unit. The sitemap, however, is driven from unit information, so it's not clear whether we should move that information or not.
abijah
2009-08-13 02:37:37 +00:00
af935ffd39
Changed naming to match that on the lease page
abijah
2009-08-12 23:16:36 +00:00
bd52030984
Changed naming to match that on the lease page
abijah
2009-08-12 23:16:36 +00:00
a15466df50
Fixed bug causing a $0.00 security deposit charge on the move-in invoice
abijah
2009-08-12 23:16:17 +00:00
f23726783e
Fixed bug causing a $0.00 security deposit charge on the move-in invoice
abijah
2009-08-12 23:16:17 +00:00
f9ff27cad4
Many bug fixes, found while entering real facility data. Most are quite minor, although there was a functionality change to assignCredits, to support concessions without assigning them to anything other than rent. I've found that there is a glaring problem with charge reversals, which don't work correctly with the collected report. Of course, we're deleting prior disbursements, which obviously needs to be rectified.
abijah
2009-08-12 09:37:49 +00:00
1d27b4dcb5
Many bug fixes, found while entering real facility data. Most are quite minor, although there was a functionality change to assignCredits, to support concessions without assigning them to anything other than rent. I've found that there is a glaring problem with charge reversals, which don't work correctly with the collected report. Of course, we're deleting prior disbursements, which obviously needs to be rectified.
abijah
2009-08-12 09:37:49 +00:00
e33741f579
Made viewing the deposit slip the default action when viewing the list of deposit transactions.
abijah
2009-08-11 18:25:40 +00:00
e74f8987d9
Made viewing the deposit slip the default action when viewing the list of deposit transactions.
abijah
2009-08-11 18:25:40 +00:00
6b3266f022
Implemented very crude attempt at security privleges. This is not really intended to be security, just a quick and dirty mechanism to avoid prying eyes. More robust security is left to future implementation.
abijah
2009-08-11 18:22:21 +00:00
9c55a047a8
Implemented very crude attempt at security privleges. This is not really intended to be security, just a quick and dirty mechanism to avoid prying eyes. More robust security is left to future implementation.
abijah
2009-08-11 18:22:21 +00:00
b1dfe5bd50
Added ability to customize the action on grid links
abijah
2009-08-11 17:30:12 +00:00
6f2038f7b0
Added ability to customize the action on grid links
abijah
2009-08-11 17:30:12 +00:00
3696aa011c
Removed the Signed column from the leases grid unless requested
abijah
2009-08-11 17:04:21 +00:00
ec22f4b003
Removed the Signed column from the leases grid unless requested
abijah
2009-08-11 17:04:21 +00:00
70629e360b
Added the Batch Number to ACH entries. This is the unique number of each initiated batch, and is what would show up on a bank statement or used by the bank to track down an ACH transaction.
abijah
2009-08-11 16:22:09 +00:00
6e03664f28
More tweaking with grids that need to be reloaded immediately after page load. Fixed a bug with the statement_entry balance field, as there were two of them.
abijah
2009-08-11 15:56:40 +00:00
fc4e812d67
More tweaking with grids that need to be reloaded immediately after page load. Fixed a bug with the statement_entry balance field, as there were two of them.
abijah
2009-08-11 15:56:40 +00:00
b6ee958c35
Marked off several to-do items
abijah
2009-08-11 15:21:50 +00:00
1b0d752a55
Modified the statement entries grid, as well as the underlying controller, to support a couple new fields, 'applied' and 'balance'.
abijah
2009-08-11 07:27:56 +00:00
f82df229f2
Modified the statement entries grid, as well as the underlying controller, to support a couple new fields, 'applied' and 'balance'.
abijah
2009-08-11 07:27:56 +00:00
9cac7f481e
Finally have a (slightly kludgy) fix for keeping the 'collected' grid from being rendered before ready.
abijah
2009-08-11 07:24:52 +00:00
abijah