91f5ad7660
Added HR to keep the boundary between two pr blocks clear even when the output is collapsed and the stack trace is not.
abijah
2009-08-03 20:17:14 +00:00
4707f3314d
Added HR to keep the boundary between two pr blocks clear even when the output is collapsed and the stack trace is not.
abijah
2009-08-03 20:17:14 +00:00
14d896d1b3
Added ability to log items without showing the output. I doubt the mechanism works perfectly in all cases, but it works enough for now and I can tweak it as needed.
abijah
2009-08-03 20:13:48 +00:00
ac2b1530fc
Added ability to log items without showing the output. I doubt the mechanism works perfectly in all cases, but it works enough for now and I can tweak it as needed.
abijah
2009-08-03 20:13:48 +00:00
d2795e8201
Added the ability to suppress logging at display time. I'd like to add an additional log level, the first which passes or suppresses the print, and the second which defaultly displays or hides the output. Perhaps next checkin.
abijah
2009-08-03 19:41:49 +00:00
a5d3ff0b70
Added the ability to suppress logging at display time. I'd like to add an additional log level, the first which passes or suppresses the print, and the second which defaultly displays or hides the output. Perhaps next checkin.
abijah
2009-08-03 19:41:49 +00:00
df91125e96
Added stack tracing to each model::pr print
abijah
2009-08-03 18:38:35 +00:00
adc87c0763
Added stack tracing to each model::pr print
abijah
2009-08-03 18:38:35 +00:00
7fda78f820
Added ability to waive a partial charge.
abijah
2009-08-03 04:14:44 +00:00
7d81b9766b
Added ability to waive a partial charge.
abijah
2009-08-03 04:14:44 +00:00
a59d93ebee
First pass at a charge waiver implementation. It hasn't been tested but for a tiny bit.
abijah
2009-08-03 03:46:58 +00:00
1aa6273ade
First pass at a charge waiver implementation. It hasn't been tested but for a tiny bit.
abijah
2009-08-03 03:46:58 +00:00
fe66241ca1
Work around for the fact that our implementation has issues with receipts of more than one tender. See the branch statement_ledger_entry_tie_20090802 for more information.
abijah
2009-08-03 03:45:51 +00:00
2c08405d5a
Work around for the fact that our implementation has issues with receipts of more than one tender. See the branch statement_ledger_entry_tie_20090802 for more information.
abijah
2009-08-03 03:45:51 +00:00
4c8e3b380e
Left r466 with syntax error... fixed that
abijah
2009-08-03 02:30:29 +00:00
e2ed6ed1c7
Left r466 with syntax error... fixed that
abijah
2009-08-03 02:30:29 +00:00
ae09d160bb
Captured some thoughts, some experiments on how to tie statement entry to ledger entry. It's not at all clear we want to go down this (or any other) path at the moment. This checkin will probably go nowhere, as I'm going to see if we can make do with the current implementation.
statement_ledger_entry_tie_20090802
abijah
2009-08-03 02:19:39 +00:00
4ee9c99e30
It's clear that the current statement entry solution is a problem, since a) the account_id member of StatementEntry is not accurate when multiple ledger entries contribute to a single statement entry, and b) there is no definitive way to tie StatementEntry to LedgerEntry. The latter isn't too big an issue, but it would certainly be a problem if we allowed transaction editing. If user wanted to change a statement entry account (say from rent to late charge, or from check to cash), there wouldn't be an absolute way to know which ledger entry(ies) to change as well.
abijah
2009-08-03 02:14:20 +00:00
6b357fc285
Added a new statement entry type, 'WAIVE', and added the beginnings of a function to add a new waiver transaction. Haven't even started the work yet though...
abijah
2009-08-02 22:44:55 +00:00
cb716b06b7
Added a new statement entry type, 'WAIVE', and added the beginnings of a function to add a new waiver transaction. Haven't even started the work yet though...
abijah
2009-08-02 22:44:55 +00:00
a9ef3a75ae
Added a check to ensure we're not adding a close with no accounts. This check should probably be in the model, but that can be done later.
abijah
2009-08-01 01:48:07 +00:00
35d7656bc5
Added a check to ensure we're not adding a close with no accounts. This check should probably be in the model, but that can be done later.
abijah
2009-08-01 01:48:07 +00:00
267357a0f7
Combined the addNsf and addTransaction functions, which was always intended. There is more that could be done, but not all bugs are flushed out yet. Its close enough though, that I want to capture it as is to help work through the subtle issues.
abijah
2009-08-01 01:47:11 +00:00
8818ad7a80
Combined the addNsf and addTransaction functions, which was always intended. There is more that could be done, but not all bugs are flushed out yet. Its close enough though, that I want to capture it as is to help work through the subtle issues.
abijah
2009-08-01 01:47:11 +00:00
1c2c2b457c
More work on handling security deposit utilizations. This is headed in the right direction, but unfortunately, there is a problem if the security deposits have not been paid. I could just ignore it, because it's a low priority problem, but I think the solution might be to just provide a waiver on the unpaid charges. Since I need to implement fee waivers anyway, I'll just move onto that next, and then finish out the security deposit work.
abijah
2009-07-31 21:11:00 +00:00
15a4528e75
More work on handling security deposit utilizations. This is headed in the right direction, but unfortunately, there is a problem if the security deposits have not been paid. I could just ignore it, because it's a low priority problem, but I think the solution might be to just provide a waiver on the unpaid charges. Since I need to implement fee waivers anyway, I'll just move onto that next, and then finish out the security deposit work.
abijah
2009-07-31 21:11:00 +00:00
b00944a412
Changed the reconciledSet to provide an option for returning partially reconciled results. This keeps the same behavior so as not to break anything (although I can only think of paid rents that might suffer).
abijah
2009-07-31 21:07:00 +00:00
44e4477d38
Changed the reconciledSet to provide an option for returning partially reconciled results. This keeps the same behavior so as not to break anything (although I can only think of paid rents that might suffer).
abijah
2009-07-31 21:07:00 +00:00
4ef09080be
Left a syntax error on the last checkin :-/
abijah
2009-07-31 19:23:19 +00:00
c4cc3ea812
Left a syntax error on the last checkin :-/
abijah
2009-07-31 19:23:19 +00:00
b41ce38526
Fixed a couple small bugs with assignCredits, one of which was causing charges to get paid out of order.
abijah
2009-07-31 19:20:35 +00:00
1e10fbbf38
Fixed a couple small bugs with assignCredits, one of which was causing charges to get paid out of order.
abijah
2009-07-31 19:20:35 +00:00
645a3a4797
Removed the ability to NSF items like Cash
abijah
2009-07-31 18:19:20 +00:00
8e0270cc82
Removed the ability to NSF items like Cash
abijah
2009-07-31 18:19:20 +00:00
3a95a994cf
Updated todo and requirements
abijah
2009-07-31 18:13:26 +00:00
8f79f0401f
Added a way to associate the meaningful part of NSF with the corresponding tender.
abijah
2009-07-31 18:10:48 +00:00
00c99ea60a
Added a way to associate the meaningful part of NSF with the corresponding tender.
abijah
2009-07-31 18:10:48 +00:00
e40778ddbd
Doh! So someone actually _was_ using the gridDataFilterConditionsStatement function. Guess it would have been worth grepping for...
abijah
2009-07-31 17:57:30 +00:00
e09fb7d258
Doh! So someone actually _was_ using the gridDataFilterConditionsStatement function. Guess it would have been worth grepping for...
abijah
2009-07-31 17:57:30 +00:00
6b7ce60ae3
Changed the default log level to 5, since we're using rather high levels anyway.
abijah
2009-07-31 17:43:51 +00:00
37e7212abe
Changed the default log level to 5, since we're using rather high levels anyway.
abijah
2009-07-31 17:43:51 +00:00
2b09f4054f
Added some comments, and changed the nsf action to redirect to viewing the tender after creation.
abijah
2009-07-31 17:15:17 +00:00
655e0c3940
Added some comments, and changed the nsf action to redirect to viewing the tender after creation.
abijah
2009-07-31 17:15:17 +00:00
33a677431f
Some cleanup from the last checkin
abijah
2009-07-31 16:48:27 +00:00
e47a2cc7aa
Some cleanup from the last checkin
abijah
2009-07-31 16:48:27 +00:00
9bd37ba282
Added the ability to perform partial deposits. After this checkin, I'll clean up some of the commented out sections of things that we're attempted to get this all working.
abijah
2009-07-31 16:41:56 +00:00
0cdcb6252e
Added the ability to perform partial deposits. After this checkin, I'll clean up some of the commented out sections of things that we're attempted to get this all working.
abijah
2009-07-31 16:41:56 +00:00
53a8d8fc60
Fixed a bug where the condition is of the form array('field' => null). That's a valid condition, but was being treated the same as array('field'). This resolves it, although it will break anyone using the gridDataFilterConditionsStatement virtual function. I don't think anyone is at the moment, although I didn't check.
abijah
2009-07-31 03:46:59 +00:00
bbec6ccbb6
Fixed a bug where the condition is of the form array('field' => null). That's a valid condition, but was being treated the same as array('field'). This resolves it, although it will break anyone using the gridDataFilterConditionsStatement virtual function. I don't think anyone is at the moment, although I didn't check.
abijah
2009-07-31 03:46:59 +00:00
91fdef9997
Must have had a brain freeze to be placing closing monies directly in Equity, since it is a credit account and doing so only ran the account into a negative balance. Transfers out of A/R need to go to an asset account, and so I reverted this back to Closing.
abijah
2009-07-31 03:36:11 +00:00
4c7e3d1f58
Removed the comment block, since it's not longer needed and has now been saved.
abijah
2009-07-31 03:29:17 +00:00
3e2d219c8d
Removed the comment block, since it's not longer needed and has now been saved.
abijah
2009-07-31 03:29:17 +00:00
5dc5f087ba
Added an automatic $35 nsf charge when marking an item as nsf. This required removing the lease_id requirement when adding a transaction, since the charge is not associated with a lease, just a customer. The requirement was artificial anyway; imagine selling POS items to folks that don't even lease from us...
abijah
2009-07-31 03:07:34 +00:00
57d593fc38
Added an automatic $35 nsf charge when marking an item as nsf. This required removing the lease_id requirement when adding a transaction, since the charge is not associated with a lease, just a customer. The requirement was artificial anyway; imagine selling POS items to folks that don't even lease from us...
abijah
2009-07-31 03:07:34 +00:00
46744a24d3
Modified to use the logging mechanism
abijah
2009-07-31 02:09:45 +00:00
65b7137f21
Modified to use the logging mechanism
abijah
2009-07-31 02:09:45 +00:00
b553dbb9c3
Modified to use the logging mechanism
abijah
2009-07-31 01:45:57 +00:00
323519ab75
Modified to use the logging mechanism
abijah
2009-07-31 01:45:57 +00:00
3c390d940f
Modified how NSF customer surplus items are handled. Instead of creating a negative surplus (which was dumb, but a decent first pass), we just void out the surplus. This drops the surplus off the radar, and in fact may cause confusion since the transaction no longer has enough statement entries to total up correctly. However, it doesn't appear too confusing, especially as tender item names are now decorated with strikethrough when they're NSF (the previous checkin).
abijah
2009-07-31 01:40:16 +00:00
a1a9c7800b
Modified how NSF customer surplus items are handled. Instead of creating a negative surplus (which was dumb, but a decent first pass), we just void out the surplus. This drops the surplus off the radar, and in fact may cause confusion since the transaction no longer has enough statement entries to total up correctly. However, it doesn't appear too confusing, especially as tender item names are now decorated with strikethrough when they're NSF (the previous checkin).
abijah
2009-07-31 01:40:16 +00:00
777a47a27b
Added strikethrough over the tender name in grids when the tender is NSF. This helps really call out the situation with NSF items.
abijah
2009-07-31 01:38:53 +00:00
fe17f87f7d
Added strikethrough over the tender name in grids when the tender is NSF. This helps really call out the situation with NSF items.
abijah
2009-07-31 01:38:53 +00:00
237b0a901f
Shrunk the comment column in half, since it's usually empty. All we really need is an easy way to spot that there is a comment, and the user can hover or widen the column as needed.
abijah
2009-07-31 01:35:45 +00:00
6b9279f5b0
Shrunk the comment column in half, since it's usually empty. All we really need is an easy way to spot that there is a comment, and the user can hover or widen the column as needed.
abijah
2009-07-31 01:35:45 +00:00
393d9c9d77
Removed the Tender column from grids where the account does not support payments and so the ledger entries should never have a Tender anyway (except for our special case Closing account, which is fine to ignore).
abijah
2009-07-31 01:34:45 +00:00
2882b1917c
Removed the Tender column from grids where the account does not support payments and so the ledger entries should never have a Tender anyway (except for our special case Closing account, which is fine to ignore).
abijah
2009-07-31 01:34:45 +00:00
17cd00c90e
Renamed prExit to prReturn, to be consitent with the return statement where it should be used. Also, modified the chargePaymentFields to be more explicit on the balance, in anticipation of the new type VOID
abijah
2009-07-31 01:31:45 +00:00
f707448b05
Renamed prExit to prReturn, to be consitent with the return statement where it should be used. Also, modified the chargePaymentFields to be more explicit on the balance, in anticipation of the new type VOID
abijah
2009-07-31 01:31:45 +00:00
066acd14f0
Changed prints to use the new logging system
abijah
2009-07-31 01:23:27 +00:00
5247139fe8
Changed prints to use the new logging system
abijah
2009-07-31 01:23:27 +00:00
87db010dc1
Discovered that an earlier implementation of Model::pr is now being overridden by the AppModel. This is probably a good thing, but it does mean that we're getting a ton of Model prints that we don't want. I added a class logging mechanism to allow individual classes to be turned up or down, and set the default for Model to be very low
abijah
2009-07-31 00:00:10 +00:00
d2a4021d6f
Discovered that an earlier implementation of Model::pr is now being overridden by the AppModel. This is probably a good thing, but it does mean that we're getting a ton of Model prints that we don't want. I added a class logging mechanism to allow individual classes to be turned up or down, and set the default for Model to be very low
abijah
2009-07-31 00:00:10 +00:00
9360ebe661
Added the debug file/line output directly into the AppModel::_pr function, as the builtin pr function simply logs the same file line for every call.
abijah
2009-07-30 23:32:10 +00:00
b759f29d91
Added the debug file/line output directly into the AppModel::_pr function, as the builtin pr function simply logs the same file line for every call.
abijah
2009-07-30 23:32:10 +00:00
32c81b7367
Finally added a logging mechanism. Only one file has been converted at the moment. I'll go in pieces, as debugging goes on.
abijah
2009-07-30 23:20:47 +00:00
c0d26a8e95
Finally added a logging mechanism. Only one file has been converted at the moment. I'll go in pieces, as debugging goes on.
abijah
2009-07-30 23:20:47 +00:00
0b8d8fe1ac
Changed the StatementEntry type enum from CREDIT to SURPLUS. I never liked using the term CREDIT, since its use is confusing along side DEBIT/CREDIT. I couldn't think of another name earlier, which is why I used CREDIT, but I decided anything other than CREDIT is good, so I chose SURPLUS.
abijah
2009-07-30 21:40:38 +00:00
a1f30804a7
Changed the StatementEntry type enum from CREDIT to SURPLUS. I never liked using the term CREDIT, since its use is confusing along side DEBIT/CREDIT. I couldn't think of another name earlier, which is why I used CREDIT, but I decided anything other than CREDIT is good, so I chose SURPLUS.
abijah
2009-07-30 21:40:38 +00:00
55b3ec947e
Logged a new bug
abijah
2009-07-30 21:39:07 +00:00
0cb961925d
The conditions were clamped down too tight, as they prevented something like 'Table.field !='
abijah
2009-07-30 21:34:03 +00:00
876d9b3d33
The conditions were clamped down too tight, as they prevented something like 'Table.field !='
abijah
2009-07-30 21:34:03 +00:00
fbfc973dad
Included a possible mechanism for including the nsf ledger entries when viewing a tender
abijah
2009-07-30 21:06:02 +00:00
d33bf24958
Included a possible mechanism for including the nsf ledger entries when viewing a tender
abijah
2009-07-30 21:06:02 +00:00
24f245c3c8
Tweaked filtering to allow for non-trivial conditions
abijah
2009-07-30 20:59:33 +00:00
424cb0ea4f
Tweaked filtering to allow for non-trivial conditions
abijah
2009-07-30 20:59:33 +00:00
e7e3dbc559
Modified the filtering behavior; A filter specified as 'Table.field' results in the obvious split (Table, field); 'Table' results in (Table, id); 'field' results in (ModelTable, field). Fixed a bug in the app controller which was allowing 'fields' to leak into the top level of 'link'
abijah
2009-07-30 19:45:19 +00:00
63de30d392
Modified the filtering behavior; A filter specified as 'Table.field' results in the obvious split (Table, field); 'Table' results in (Table, id); 'field' results in (ModelTable, field). Fixed a bug in the app controller which was allowing 'fields' to leak into the top level of 'link'
abijah
2009-07-30 19:45:19 +00:00
de0cf6467a
Moved the filtering split to a virtual function.
abijah
2009-07-30 19:07:21 +00:00
07232c77d5
Moved the filtering split to a virtual function.
abijah
2009-07-30 19:07:21 +00:00
48fb7383de
Added effective date to each NSF entry, and fixed the account bug with receipts/payments. There is still a bug/question on how to handle nsf credits. It would be nice to simply delete the credit, since the check bounced, but then the original transaction will not add up. Either we decide that it doesn't need to add up, figure out a different type for the credit, or add a void flag to each statement entry and just void out nsf items. Or instead of a void flag, have an nsf_statement_entry_id which will also tie the payment/credit to the nsf payment/credit.
abijah
2009-07-30 18:23:37 +00:00
1e7557de71
Added effective date to each NSF entry, and fixed the account bug with receipts/payments. There is still a bug/question on how to handle nsf credits. It would be nice to simply delete the credit, since the check bounced, but then the original transaction will not add up. Either we decide that it doesn't need to add up, figure out a different type for the credit, or add a void flag to each statement entry and just void out nsf items. Or instead of a void flag, have an nsf_statement_entry_id which will also tie the payment/credit to the nsf payment/credit.
abijah
2009-07-30 18:23:37 +00:00
94c0efa881
This is probably what we really want for NSF... two transactions. One for backing out the bank deposit, and the other for adjusting A/R and all the associated statement entries. This is working reasonably well, even seemingly fine for the collected rents report. I do see that there is another bug though, that is causing statement entries to have the opposite account_id than intended (A/R instead of Cash) when entering new receipts. Not sure when I broke that, but it must have been when working on deposits.
abijah
2009-07-30 07:30:50 +00:00
d91957faed
This is probably what we really want for NSF... two transactions. One for backing out the bank deposit, and the other for adjusting A/R and all the associated statement entries. This is working reasonably well, even seemingly fine for the collected rents report. I do see that there is another bug though, that is causing statement entries to have the opposite account_id than intended (A/R instead of Cash) when entering new receipts. Not sure when I broke that, but it must have been when working on deposits.
abijah
2009-07-30 07:30:50 +00:00
7450d2a98e
Preliminary work on NSF. It's far from working, but we're headed in the right direction.
abijah
2009-07-30 06:29:41 +00:00
abijah